From 811006b4cef2bfa890676b41bd90f40a64f40bf7 Mon Sep 17 00:00:00 2001 From: Lai Jiangshan Date: Tue, 11 Mar 2014 22:15:24 +0800 Subject: [PATCH] tools/xcutils: xc_save: avoid allocing local constant string cmd_str doesn't need to be allocated. Signed-off-by: Lai Jiangshan Acked-by: Ian Jackson --- tools/xcutils/xc_save.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/xcutils/xc_save.c b/tools/xcutils/xc_save.c index ecf54440c3..654c9c25cd 100644 --- a/tools/xcutils/xc_save.c +++ b/tools/xcutils/xc_save.c @@ -127,8 +127,7 @@ static int switch_qemu_logdirty(int domid, unsigned int enable, void *data) if (!xs_watch(xs, path, "qemu-logdirty-ret")) errx(1, "can't set watch in store (%s)\n", path); - if (!(cmd_str = strdup( enable == 0 ? "disable" : "enable"))) - errx(1, "can't get logdirty cmd path in store"); + cmd_str = enable == 0 ? "disable" : "enable"; /* Tell qemu that we want it to start logging dirty page to Xen */ strcpy(p, "cmd"); @@ -156,7 +155,6 @@ static int switch_qemu_logdirty(int domid, unsigned int enable, void *data) goto read_again; free(path); - free(cmd_str); free(ret_str); return 0; -- 2.30.2